Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] libxkbcommon package is missing compose-data as dependency #8273

Open
enen92 opened this issue Nov 1, 2023 · 0 comments
Open

[BUG] libxkbcommon package is missing compose-data as dependency #8273

enen92 opened this issue Nov 1, 2023 · 0 comments

Comments

@enen92
Copy link

enen92 commented Nov 1, 2023

Describe the bug

As stated in the documentation for xkbcommon the library relies on the compose files provided by libX11 to be able to handle dead-key and key composing support:

Compose is distributed in libX11, as part of the X locale data.

Support in Kodi was added for wayland in xbmc/xbmc#23943 and is was done for generic libinput in xbmc/xbmc#24044.

To test this I added libx11 as a dependency for libxkcommon:

diff --git a/packages/wayland/libxkbcommon/package.mk b/packages/wayland/libxkbcommon/package.mk
index 23035a3899..9868361941 100644
--- a/packages/wayland/libxkbcommon/package.mk
+++ b/packages/wayland/libxkbcommon/package.mk
@@ -8,7 +8,7 @@ PKG_SHA256="0edc14eccdd391514458bc5f5a4b99863ed2d651e4dd761a90abf4f46ef99c2b"
 PKG_LICENSE="MIT"
 PKG_SITE="https://xkbcommon.org"
 PKG_URL="https://xkbcommon.org/download/${PKG_NAME}-${PKG_VERSION}.tar.xz"
-PKG_DEPENDS_TARGET="toolchain xkeyboard-config libxml2"
+PKG_DEPENDS_TARGET="toolchain libX11 xkeyboard-config libxml2"
 PKG_LONGDESC="xkbcommon is a library to handle keyboard descriptions."
 
 PKG_MESON_OPTS_TARGET="-Denable-docs=false"

which is obviously wrong since libx11 includes much more than just the compose data. Other distros like debian ship its own package (libx11-data) https://packages.debian.org/bookworm/libx11-data, gentoo with compose-tables (https://packages.gentoo.org/packages/x11-misc/compose-tables), etc.
Also yocto/openembedded have a recipe for libx11-compose-data: https://git.yoctoproject.org/poky/plain/meta/recipes-graphics/xorg-lib/libx11-compose-data_1.8.4.bb.

As far as I can tell libx11 does not provide any way to build only the compose tables. So a possible solution would be to extend the libx11 package (building it) and only actually install the compose files (those in /usr/share/X11/locale/). Since I know nothing about extending existing recipes nor even what the best approach is to handle this, I opted for a bug report.

Feel free to close if you feel this is a feature request, I don't have a forum account.

@enen92 enen92 changed the title [BUG] libxkbcommon package is missing compose-data as dependencies [BUG] libxkbcommon package is missing compose-data as dependency Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants