Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Wayland build fails #8271

Closed
heitbaum opened this issue Nov 1, 2023 · 2 comments · Fixed by #9357
Closed

[BUG] Wayland build fails #8271

heitbaum opened this issue Nov 1, 2023 · 2 comments · Fixed by #9357

Comments

@heitbaum
Copy link
Contributor

heitbaum commented Nov 1, 2023

Describe the bug

Since xbmc/xbmc#23612 the Wayland build fails

CMake Error at cmake/scripts/linux/ExtraTargets.cmake:39 (add_dependencies):
  Cannot add target-level dependencies to non-existent target "libkodi".

  The add_dependencies works for top-level logical targets created by the
  add_executable, add_library, or add_custom_target commands.  If you want to
  add file-level dependencies see the DEPENDS option of the add_custom_target
  and add_custom_command commands.
Call Stack (most recent call first):
  CMakeLists.txt:581 (include)

How to reproduce

Steps to reproduce the behavior:

  1. PROJECT=Generic ARCH=x86_64 DEVICE=wayland make image

Information

  • LibreELEC Version: [e.g. 9.2.1] LE12
  • Hardware Platform: [e.g. RPi3] wayland

Log file

Context

@heitbaum
Copy link
Contributor Author

heitbaum commented Oct 3, 2024

Further info
PROJECT=Generic ARCH=x86_64 DEVICE=wayland s/build kodi:host fails
But
PROJECT=Generic ARCH=x86_64 DEVICE=wayland s/build kodi:target doesn’t fail

The host build can be made to succeed by commenting the following line (2nd last) in the file cmake/scripts/linux/ExtraTargets.cmake

add_dependencies(lib${APP_NAME_LC} generate-wayland-extra-protocols)

then removing the comment before executing the :target build.

@jernejsk
Copy link
Member

jernejsk commented Oct 3, 2024

I guess it's time to update our hack patch for quick addon builds. I'll look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants