Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/fix bugs #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ services:

```bash
# The postgres service is executed separated to be possible reuse this service to other applications that use PostgreSQL
docker compose up -f docker-compose-postgres.yml -d
docker compose -f docker-compose-postgres.yml up -d
docker compose up -d
docker compose -d
```
Expand Down
20 changes: 7 additions & 13 deletions docker-compose-postgres.yml
Original file line number Diff line number Diff line change
@@ -1,23 +1,17 @@
networks:
postgres:
external: true
name: postgres
Comment on lines -2 to -4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This network is necessary to be possible connect the service app at this network.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually service app uses only internal network.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about create a new repository specific to PostgreSQL and to put all documentation about PostgreSQL at the newest repository?

internal:
driver: bridge

services:
postgres:
image: postgres:11-alpine
image: postgres:${POSTGRES_VERSION:-17}-alpine
restart: always
volumes:
- ./volumes/postgres/data:/var/lib/postgresql/data
environment:
- POSTGRES_DB
- POSTGRES_USER
- POSTGRES_DB=${POSTGRES_DB:-nextcloud}
- POSTGRES_USER=${POSTGRES_USER:-nextcloud}
- POSTGRES_PASSWORD
networks:
- postgres
app:
networks:
- postgres
cron:
networks:
- postgres
- internal