Mail translations #423
Merged
Mail translations #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
September 25, 2024 11:29
Those should only be provided by the user.
The name is misleading, as it's not the default.language setting
DisplayLocalized in SmartyPage was never called DisplayLocalized in Page was only a copy, which is still called, but the languageCode parameter is not used.
..but only when custom template is available for default lang. refs LibreBooking#416
It conflicts with the now protected email property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue managing custom mail templates and also provides an option to enforce custom translations if possible.
Closes #416
Fixes #424
During the implementation i also encountered the bug #425. When an email is sent, it changes the browser session language to the language of the target user.
To me the entire translation system and mail system is kind of a mess. I tried refactor the mailing logic to a builder pattern. But as I always stumbled on new hurdles I gave up. See #426