Resurrect unit tests #408
Merged
Resurrect unit tests #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 31, 2024 07:16
Adapt path for phpunit script
Make tests executable
The entire helper class does not seem useful to me. I Just made it work.
hakito
force-pushed
the
develop
branch
4 times, most recently
from
497ddb8
to
3354db5
Compare
|
I haven't reviewed but really like the idea of getting working unit tests. Thank you! |
|
Great work, I really wanted to bring back unit tests, but it was really in my list os priorities, so thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests seem to be broken for quite a long time. This makes it difficult to contribute to the project without breaking something essential.
So this PR is focused on fixing the phpunit tests. It covers the following changes.
I also adapted the script part in the composer.json. However without the .phive environment the
lintcall will fail because of the missing tools directory.Actually I'd suggest to get rid of the .phive stuff.