Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported and tested version on Getting Ready (setup.md) #333

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

emcaulay
Copy link
Contributor

@emcaulay emcaulay commented Jan 17, 2024

I updated the version that this lesson is tested with from 3.6.1 to 3.7.7.

I taught this lesson through episode 9, and everything worked correctly with the latest version of Open Refine that I had downloaded (3.7.7).

I updated the version that this lesson is tested with from 3.6.1 to 3.7.7. 

I taught this lesson through episode 9, and everything worked correctly with the latest version of Open Refine that I had downloaded (3.7.7).
Copy link

github-actions bot commented Jan 17, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-333

The following changes were observed in the rendered markdown documents:

 md5sum.txt | 2 +-
 setup.md   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-01-17 22:49:11 +0000

@emcaulay
Copy link
Contributor Author

@jas58 , I mentioned this PR during our Maintainers Meeting today, and I was able to make the PR and submit it. Hopefully it's helpful, but as I didn't teach all the way through the lesson, I can understand it you want it to be more completely tested.

github-actions bot pushed a commit that referenced this pull request Jan 17, 2024
@ostephens
Copy link
Contributor

Thanks so much for doing this @emcaulay
I've checked the remainder of the lesson with 3.7.7 and it all works so I think we are good to merge this

@ostephens ostephens self-requested a review February 9, 2024 14:29
@ostephens ostephens merged commit ecc456b into LibraryCarpentry:main Feb 9, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 9, 2024
Auto-generated via {sandpaper}
Source  : ecc456b
Branch  : main
Author  : Owen Stephens <[email protected]>
Time    : 2024-02-09 15:10:44 +0000
Message : Merge pull request #333 from emcaulay/patch-1

Update supported and tested version on Getting Ready (setup.md)
github-actions bot pushed a commit that referenced this pull request Feb 9, 2024
Auto-generated via {sandpaper}
Source  : af90b19
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-02-09 15:11:55 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : ecc456b
Branch  : main
Author  : Owen Stephens <[email protected]>
Time    : 2024-02-09 15:10:44 +0000
Message : Merge pull request #333 from emcaulay/patch-1

Update supported and tested version on Getting Ready (setup.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants