Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant pyautogui library, replace with existing keyboard module functions #28

Closed
wants to merge 1 commit into from

Conversation

sugoidogo
Copy link
Contributor

@sugoidogo sugoidogo commented Aug 26, 2024

This PR fixes #25 and removes a redundant library. Replaces all usage of pyautogui.press with keyboard.send, which additionally supports modifiers, multi-key, and raw key codes. Worth noting is that the keyboard library also includes functions for recording and playing macros, also making PyMacroRecord redundant.

@Lenochxd Lenochxd self-assigned this Aug 27, 2024
@sugoidogo
Copy link
Contributor Author

It's also worth noting is that PyAutoGui also includes a dedicated hotkey function that could be used for the /key command for multi-key hotkeys, but sequences with modifiers would require more complicated logic using the hold context manager and there's no apparent function for macro recording/playback at all, which is why I feel like keyboard is the better choice.

@Lenochxd
Copy link
Owner

Lenochxd commented Sep 11, 2024

Hi, thank you for the contribution! Unfortunately, I’ll have to close this PR for 3 reasons:

  1. Removing pyautogui would break existing functionality, particularly for buttons that rely on it to execute Python code.
  2. The cleanup of both keyboard and pyautogui has already been made in the tidy-up branch.
  3. This PR doesn't add the macro functionality requested in Macros? #25.

I appreciate the effort though, and hope to see more contributions from you in the future! :)

@Lenochxd Lenochxd closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macros?
2 participants