Misc stuff #321
Merged
Misc stuff #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 26, 2024 17:22
PS. the split into a default mode as a radio group and the other modes having a dropdown for choosing the modifier is a bit awkward (and it made the code awkward as well when the default mode also has a modifer set). It's probably better that each mode gets a dropdown and 'default' being one option for in the dropdown... Oh well, future stuff. Closes #266
While I can't reproduce the issue, multiple people reported the bug ( via multiple issues). Apparently, disabling the tiling animations works around the bug. So disable the tiling animations for layouts. A proper fix would probably require implementing custom animations rather than mis-using/hooking into GNOME Shell animations. For now just use this simple workaround since this is a rather annoying bug for those who are affected and has been around for a while. Works around #304
Currently, a conflict of the window action key (Alt or Super) with a movement mode modifier of T-A is only checked and handled during enable time. But users may change the window action key while T-A is already enabled. Handle that case now as well. Previously, the modifier for the conflicting move mode was switched to the non-window-action-modifier. But that can be an issue, if that modifier is already taken by a different mode. So simply disable the modifier for the conflicting mode. Closes #313
Leleat
force-pushed
the
misc-bugfixes
branch
from
f84fefb
to
e575676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.