Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve some original changes of PKGBUILD #301

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Preserve some original changes of PKGBUILD #301

merged 1 commit into from
Oct 22, 2023

Conversation

VeldoraTheDragon
Copy link
Contributor

@VeldoraTheDragon VeldoraTheDragon commented Oct 18, 2023

The edited PKGBUILD has been tested and packages the extension correctly as expected.

@VeldoraTheDragon VeldoraTheDragon changed the title Preserve some original Change of PKGBUILD Preserve some original changes of PKGBUILD Oct 18, 2023
url="https://github.com/Leleat/Tiling-Assistant"
license=('GPL2')
depends=('gnome-shell')
depends=('gnome-shell>=40')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the version of GNOME Shell need to be explicit?

Nowadays (and for a while already) new versions of Tiling Assistant only support the latest GNOME Shell version; maybe the previous version as well, if the effort to keep the compatibility is low.

I guess that would mean AUR users would have gotten updates to Tiling Assistant that broke their extension if they were on older GNOME Shell releases. So far I haven't gotten any complaints about that... so either Tiling Assistant doesn't have a lot of AUR users and/or AUR users get newer GNOME Shell versions faster than Tiling Assistant updates to the new releases. Either way, if the version should be explicit I could add it to my release script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it seems like the "official" AUR-PKGBUILD doesn't require an explicit version of gnome-shell.
Should've checked it first.

I thought, since you had it in your old one, I would put it back in. On the other side, Arch keeps a rolling-release principle. And if users wanted to keep something like gnome 3.38, it's their responsibilty if they want to keep older software running.

It's up to you, if you want to use an explicit version or not. If you think, it's not needed anymore, remove it.
Otherwise you can keep it without issues.

@Leleat Leleat merged commit 0ebf491 into Leleat:update-pkgbuild Oct 22, 2023
3 checks passed
@VeldoraTheDragon VeldoraTheDragon deleted the patch-1 branch October 23, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants