Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Window Hint Roundness #222

Closed
Aylur opened this issue Jan 11, 2023 · 3 comments · Fixed by #344
Closed

Active Window Hint Roundness #222

Aylur opened this issue Jan 11, 2023 · 3 comments · Fixed by #344

Comments

@Aylur
Copy link

Aylur commented Jan 11, 2023

In AlwaysActiveWindowHint Class for the style you are using outline which ignores border-radius. I understand the issue why you are using outline for the outer border, and border for the inner border.
Instead of using outline how about this?

const wRect = window.get_frame_rect();
this.set({
    x: wRect.x - (outerBorderSize/2),
    y: wRect.y - (outerBorderSize/2),
    width: wRect.width + outerBorderSize
    height: wRect.height + outerBorderSize
});

Then using border-width for the inner border, with this, using border-radius would be possible.
Only issue with this is if the outerBorderSize is an odd number the border is misaligned and the corners look funky. A solution could be rounding it or letting the user know.

@Leleat
Copy link
Owner

Leleat commented Jan 14, 2023

IIRC, I thought about rounding the border but ultimately decided against it because windows can have varying degree of 'roundness' and even have a mix of rounded and not rounded corners. So it would end up looking weird...

I guess I can add a (hidden) setting to allow the user to make that choice. Although I don't have much time now since my exams are starting next month and I am also in the process of (slowly) rewriting the current code.

Leleat pushed a commit that referenced this issue May 19, 2024
This commits  basically integrates https://github.com/Leleat/focus-indicator-prototype
into Tiling Assistant. The other extension was just a prototype in
cooperation with a GNOME Designer. But it is more polished than the
active window hint that is currently in Tiling Assistant. I did some
slight refactoring. I also removed the focus indication when using
swipe gestures since the animation didn't work quite well (and had
a bug during the animation with multiple monitors).

This time however, the focus hint will be disabled by default as I don't
believe it is that useful of a feature anymore, it deviates a bit too
much from the stock GNOME behavior, and it may even be an unexpected
behavior from a users perspective, if they don't know what it is or how
it gets triggered. This is feature is also less tested as they are a lot
of permutations of situations to test (multi-monitor, workspaces on all/
primary display, etc). Additionally, it is put behind the advanced and
experimental settings toggle. Some of the settings for the focus hint
are not exposed in the UI (like the outline border radius, outline)
because I'd like to cut down on the settings. Even putting them behind
the advanced toggle doesn't feel good because eventually the advanced
settings will grow so big that there is at least one setting for someone
out there, which will eventually make the advanced settings 'mandatory'.
I kinda regret exposing so many settings in the prefs UI... oh well.

Fixes #306
Fixes #222
@EdiDD
Copy link

EdiDD commented Jul 30, 2024

It is very nice done in forge extension. You can check and maybe adapt something similar:
https://github.com/forge-ext/forge

@Leleat
Copy link
Owner

Leleat commented Jul 30, 2024

It is very nice done in forge extension. You can check and maybe adapt something similar: https://github.com/forge-ext/forge

Thanks for the hint but I've already opened an MR that addresses this: #344.

I only want to make one more release with some bugfixes before merging it. .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants