-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Active Window Hint Roundness #222
Comments
IIRC, I thought about rounding the border but ultimately decided against it because windows can have varying degree of 'roundness' and even have a mix of rounded and not rounded corners. So it would end up looking weird... I guess I can add a (hidden) setting to allow the user to make that choice. Although I don't have much time now since my exams are starting next month and I am also in the process of (slowly) rewriting the current code. |
This commits basically integrates https://github.com/Leleat/focus-indicator-prototype into Tiling Assistant. The other extension was just a prototype in cooperation with a GNOME Designer. But it is more polished than the active window hint that is currently in Tiling Assistant. I did some slight refactoring. I also removed the focus indication when using swipe gestures since the animation didn't work quite well (and had a bug during the animation with multiple monitors). This time however, the focus hint will be disabled by default as I don't believe it is that useful of a feature anymore, it deviates a bit too much from the stock GNOME behavior, and it may even be an unexpected behavior from a users perspective, if they don't know what it is or how it gets triggered. This is feature is also less tested as they are a lot of permutations of situations to test (multi-monitor, workspaces on all/ primary display, etc). Additionally, it is put behind the advanced and experimental settings toggle. Some of the settings for the focus hint are not exposed in the UI (like the outline border radius, outline) because I'd like to cut down on the settings. Even putting them behind the advanced toggle doesn't feel good because eventually the advanced settings will grow so big that there is at least one setting for someone out there, which will eventually make the advanced settings 'mandatory'. I kinda regret exposing so many settings in the prefs UI... oh well. Fixes #306 Fixes #222
It is very nice done in forge extension. You can check and maybe adapt something similar: |
Thanks for the hint but I've already opened an MR that addresses this: #344. I only want to make one more release with some bugfixes before merging it. . |
In
AlwaysActiveWindowHint
Class for the style you are using outline which ignoresborder-radius
. I understand the issue why you are usingoutline
for the outer border, andborder
for the inner border.Instead of using
outline
how about this?Then using
border-width
for the inner border, with this, usingborder-radius
would be possible.Only issue with this is if the
outerBorderSize
is an odd number the border is misaligned and the corners look funky. A solution could be rounding it or letting the user know.The text was updated successfully, but these errors were encountered: