You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm actually not sure if we do want them to be PUBLIC. It would be better to let the user chose their own version ?
Those defines only affect code from the DLL not the API boundary, and are set to convey the minimum version of Windows we support. If the user wants their patch be compatible with a more recent version of Windows, they may do it.
IIRC this was in the context of trying to use D2MOO on Windows7 ?
In that case we should probably add those defines on the D2MOO side
One example is the Windows defines at https://github.com/Lectem/D2.Detours/blob/master/source/CMakeLists.txt#L41
The text was updated successfully, but these errors were encountered: