Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defines that affect code linking against D2.Detours should be scoped PUBLIC #2

Open
fortenbt opened this issue Jun 3, 2024 · 1 comment

Comments

@fortenbt
Copy link

fortenbt commented Jun 3, 2024

One example is the Windows defines at https://github.com/Lectem/D2.Detours/blob/master/source/CMakeLists.txt#L41

@Lectem
Copy link
Owner

Lectem commented Jul 22, 2024

I'm actually not sure if we do want them to be PUBLIC. It would be better to let the user chose their own version ?
Those defines only affect code from the DLL not the API boundary, and are set to convey the minimum version of Windows we support. If the user wants their patch be compatible with a more recent version of Windows, they may do it.

IIRC this was in the context of trying to use D2MOO on Windows7 ?
In that case we should probably add those defines on the D2MOO side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants