Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub-protocol support broken #46

Open
ppmathis opened this issue Feb 2, 2013 · 0 comments
Open

Sub-protocol support broken #46

ppmathis opened this issue Feb 2, 2013 · 0 comments

Comments

@ppmathis
Copy link

ppmathis commented Feb 2, 2013

Currently the sub-protocol support is broken in websocket.io (when the hybi protocol is used). The problem is in the 'ws' package / library. It was fixed there in version 0.4.22, but websocket.io still requires 0.4.20 in its dependencies.

It should be atleast changed to 0.4.22 to support sub-protocols properly again.

Fix in 'ws' library for reference: websockets/ws@b0be70f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ppmathis