Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get.max_acc fails to calculate correct accuracy on edge case #14

Open
mmauri opened this issue Apr 23, 2019 · 0 comments
Open

get.max_acc fails to calculate correct accuracy on edge case #14

mmauri opened this issue Apr 23, 2019 · 0 comments

Comments

@mmauri
Copy link

mmauri commented Apr 23, 2019

Hi Laurae,
Congrats with this superb library.
With few observations xgboost some times returns the same probability to each one, and having the same probability with different labels makes get.max_acc report the inverse of accuracy & the max threshold also is incorrect if we assume that positive obs are > threshold (not >=)

To reproduce it:
get.max_acc(rep(0.502,8),c(0,1,1,1,1,1,1,1))

It gives 0.125 accuracy with 0.502 threshold

Thanks for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant