make filter docs use fluent syntax by default #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6.x/crud-filters.md
Outdated
| CRUD::filter('active') | ||
| ->type('simple') | ||
| ->whenActive(function ($value) { | ||
| $this->crud->addClause('where', 'active', '1'); |
There was a problem hiding this comment.
Search $this->crud->addClause & Replace with CRUD::addClause in whole document
There was a problem hiding this comment.
Search
$this->crud->addClause& Replace withCRUD::addClausein whole document
@tabacitu It's still there 21 occurrences. NOT RESOLVED
pxpm
reviewed
Aug 10, 2023
Co-authored-by: Pedro Martins <[email protected]>
tabacitu
commented
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spent quite a bit of time rewriting this page, so that:
I need help TESTING the docs here. I need someone to use the code I provided in an app, and make sure it's working they're all working expected.
@karandatwani92 can you help with that please?
--
Addresses a small part of #450