Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationship [Pro] - Not documented how to change attribute showed by pivot select #487

Closed
realtebo opened this issue Aug 3, 2023 · 7 comments
Assignees
Labels
documentation Improvements or additions to documentation Priority: SHOULD Size: XS 1 hour

Comments

@realtebo
Copy link
Contributor

realtebo commented Aug 3, 2023

Starts here: https://backpackforlaravel.com/docs/6.x/crud-fields#relationship-pro

image

The first [and only, often] info we need here is that if you specificy attribute you can switch from a select of ids to a select using some label of your choice

@karandatwani92 karandatwani92 self-assigned this Aug 3, 2023
@karandatwani92 karandatwani92 added the documentation Improvements or additions to documentation label Aug 3, 2023
@karandatwani92
Copy link
Contributor

@realtebo Thanks for pointing out the info we missed.

we will add attribute in the docs which let the devs choose another label. Thank you

@pxpm
Copy link
Contributor

pxpm commented Aug 3, 2023

That is documented. We just need to maybe link it in more places.
https://backpackforlaravel.com/docs/6.x/crud-fields#save-additional-data-to-pivot-table

@realtebo
Copy link
Contributor Author

realtebo commented Aug 4, 2023

@pxpm it's not the same

we are talking how to change the label showed in the select showed in repeatable field and in the repeatable field managed by the new relationship field.

it's not related to saving additional fata

@pxpm
Copy link
Contributor

pxpm commented Aug 4, 2023

Yeah ... maybe we need to create a separate section for it. 👍

It's there, but you need to read a bit down:
image

@karandatwani92 will takeover this and make this section more clear in the docs.

Thanks for pointing it you @realtebo 🙏

@realtebo
Copy link
Contributor Author

realtebo commented Aug 4, 2023

@pxpm Yes, i know, but my question is very specific: how can I understand that I can use 'attribute' to change the label of the select ?! Sorry for persisting to point this specific case, but it's so common that I kindly suggest to document [or at least to back-link to a point where ALL of available attributes are documented]

sorry, again, but 'if you want change something, change it here' it's not so fun in a documentation page.
We as developer need to know the full list of what is changeable, and what each parameters is called and what each does.

I hope to not was rude. Sorry, if I was.

I want ot thank your team for documentation and development work at this project. We really love it and it's the 3rd year we renew the "infinity pro" license.
We are happy because we can warn about problems, ask for little changes, and a lot of time all we hoped was implemented

@karandatwani92
Copy link
Contributor

PR Submited #496

@pxpm
Copy link
Contributor

pxpm commented Aug 14, 2023

We have already changed that bit of the docs to be a full section, and added more examples. I've merged @karandatwani92 suggestion to also add the attribute as an example.

We will investigate the possibility of creating a page similar to laravel helper methods list where we list all "Field and Column attributes".

We could create some kind of a list under each field/column docs with links to those attributes docs.

Not sure if it wouldn't bloat the docs toooo much if we name every attribute for every field type. so we may need to "group" them by some kind of categories.
Like using Common Attributes, to reference Name, Type, Label, validationRules, hint etc.

Alternatively we could move the docs 1 field/column per page, and in that case we think it's fine if we have a table with all supported attributes at the end.

I will open a separate issue for that.

Thanks for the suggestion and thanks for the PR @karandatwani92

Cheers

@pxpm pxpm closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Priority: SHOULD Size: XS 1 hour
Projects
Status: Done
Development

No branches or pull requests

3 participants