Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly misleading instructions for the "upload" field #274

Open
rafalglowacz opened this issue Nov 4, 2021 · 0 comments
Open

Slightly misleading instructions for the "upload" field #274

rafalglowacz opened this issue Nov 4, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rafalglowacz
Copy link

Hi,
this is rather minor, but the docs for the upload field state:

[   // Upload
    ...
    'disk'  => 'uploads', // if you store files in the /public folder, please omit this; if you store them in /storage or S3, please specify it;
    ...
],

So I deleted the "disk" key and upload worked fine and saved the file as exptected in storage/app/public.

Then I returned to the edit page and the value was shown like this:
company/logo/7bf6d6b07ad00115cff02dd1b552fb6b.png

It was clickable, but the link was the same as the value shown, it wasn't prefixed with "storage/", so it didn't work.

After going back to the field definition and adding 'disk' => 'public' everything started to work. So maybe the docs should state that "uploads" should be replaced with "public", not ommited?

@tabacitu tabacitu added bug Something isn't working Priority: MUST labels Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants