Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: ecdh & tea & binary & login process #33

Merged
merged 12 commits into from
May 7, 2024
Merged

optimize: ecdh & tea & binary & login process #33

merged 12 commits into from
May 7, 2024

Conversation

fumiama
Copy link
Member

@fumiama fumiama commented May 7, 2024

  • 修复二维码登录:这是将binary合并后未考虑tea加密的边界情况而新产生的bug。
  • 优化ecdh
    • 使用接口规范化ecdh密钥分发算法
    • 使用官方库的P256代替自实现的prime256v1
    • 消除全部panic,因为panic不应发生在库中而应位于调用链最末端
  • 优化登录返回处理逻辑
    • 简化冗余的(bool, error)返回值为error
    • 为直接panic的函数添加error返回,并将所有报错移动到最末端,即main.go
  • 优化binary逻辑
    • 将容易混淆含义的Pack重命名为ToBytes
    • 将带typ参数的PackPacket扶正为Pack
    • 不再允许WritePacketBytes参数为"",应使用等价的WriteBytes
  • 优化tea加密的内存分配,为此,移除tea库而使用支持EncodeTo方法的gofastTEA。该库是我修改自MiraiGo的,与之前移除的代码完全等价。

@Redmomn Redmomn merged commit 28c1113 into LagrangeDev:master May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants