Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ordering issue #30

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Fix ordering issue #30

merged 2 commits into from
Jun 4, 2024

Conversation

sveinse
Copy link
Member

@sveinse sveinse commented Jun 4, 2024

  • odg list does not sort by default
  • UI now saves JSON in sorted order

Fixes #27

@sveinse
Fix ordering issue
07c4786 
* `odg list` does not sort by default
* UI now saves JSON in sorted order
@sveinse
Add missing tests
1076dbe
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@BriacLR
Copy link

BriacLR commented Jun 4, 2024

Reviewed changes:

  • odg list sorts the objects in the correct order and grouped correctly
  • saving as .json from the ui sorts the file the same way odg list plots results
    Approved :)

@sveinse sveinse merged commit b059a05 into main Jun 4, 2024
3 checks passed
@sveinse sveinse deleted the fix-ordering-issue branch June 4, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BriacLR BriacLR BriacLR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON is order preserving, but should be strictly ordered
2 participants
@sveinse @BriacLR