Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Server Crystopia.net #657

Closed
wants to merge 9 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added minecraft_servers/crystopia/background.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added minecraft_servers/crystopia/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added minecraft_servers/crystopia/icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added minecraft_servers/crystopia/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
28 changes: 28 additions & 0 deletions minecraft_servers/crystopia/manifest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"server_name": "crystopia",
"nice_name": "Crystopia",
"direct_ip": "play.crystopia.net",
"server_wildcards": [
"mc.crystopia.net"
],
"social": {
"web": "https://crystopia.net",
"web_shop": "none",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what?! 😂 I would understand null or an empty string - But where did you get the information that we can and would handle "none" as string? 😂
So if you do not have a web shop, remove the key. It is not required. And the user will not gets a redirect to "none"!

"web_support": "https://crystopia.net/support",
"twitter": "CrystopiaNet",
"youtube": "https://www.youtube.com/@",
Copy link
Member

@JakobBruening JakobBruening Aug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot the tag ig. Update or just remove it. If I would merge your PR, our users would get many wrong redirects.. 😬😬

"discord": "https://dc.crystopia.net",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom discord invite links are only supported for LabyMod partners at the moment.
Please use a discord invite link.

Documentation reference: https://github.com/LabyMod/server-media/blob/master/docs/Manifest.md#discord-url

"teamspeak": "ts.crystopia.net"
},
"gamemodes": {
"smp": {
"name": "SMP",
"command": "/play"
},
},
"discord": {
"server_id": 1084507325450162247,
"rename_to_minecraft_name": false
},
"yt_trailer": "coming"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO, NO, NO!!!!
No "coming", "none" or empty links! Remove! Remove! Remove!

}
Loading