Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SchokiefyNET #1426

Merged
merged 5 commits into from
Nov 6, 2024
Merged

add SchokiefyNET #1426

merged 5 commits into from
Nov 6, 2024

Conversation

Chiefkommander
Copy link
Contributor

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/schokiefynet/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

},
"discord": {
"server_id": 489529070913060867,
"rename_to_minecraft_name": true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reserved for partners
Change to false

"social": {
"web": "https://www.schokiefy.net",
"web_shop": "https://www.schokiefy.net/shop",
"web_support": "https://www.schokiefy.net/support",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot be behind login
Has to be FAQ or contact form or similar

@DoJapHD DoJapHD merged commit 85aca4c into LabyMod:master Nov 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants