Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .columns file dependence #53

Open
sschmidt23 opened this issue Sep 19, 2024 · 1 comment
Open

Remove .columns file dependence #53

sschmidt23 opened this issue Sep 19, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@sschmidt23
Copy link
Collaborator

Having to read in a few numbers from a .columns file rather than via a config param is annoying, and a remnant of how DESC_BPZ does things. It should be simple to remove the one or two things that are read from .columns and instead make those config params.

@sschmidt23 sschmidt23 added the enhancement New feature or request label Sep 19, 2024
@sschmidt23 sschmidt23 self-assigned this Sep 19, 2024
@sschmidt23
Copy link
Collaborator Author

Looking at the code, it's even less involved than I thought, I thought that we read the names of the mags, mag_errs, and zp_offsets from the columns file, but I already moved those to config params, the only remaining thing in the .columns is the filter names, should be trivial to move that to a config param.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant