Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing unit tests #42

Open
2 of 3 tasks
OliviaLynn opened this issue Nov 30, 2023 · 2 comments
Open
2 of 3 tasks

Failing unit tests #42

OliviaLynn opened this issue Nov 30, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@OliviaLynn
Copy link
Member

Bug report
The unit tests appear to be failing,

  • locally
  • in the smoke test workflow (log)
=========================== short test summary info ============================
FAILED tests/test_algos.py::test_bpz_lite - assert False
 +  where False = <built-in method all of numpy.ndarray object at 0x7fb1806e16b0>()
 +    where <built-in method all of numpy.ndarray object at 0x7fb1806e16b0> = array([ True,  True, False, False, False,  True, False,  True, False,\n        True]).all
 +      where array([ True,  True, False, False, False,  True, False,  True, False,\n        True]) = <function isclose at 0x7fb1abe892b0>(array([0.16, 0.12, 0.  , 0.12, 0.05, 0.14, 0.11, 0.14, 0.05, 0.16]), array([0.16, 0.12, 0.14, 0.14, 0.06, 0.14, 0.12, 0.14, 0.06, 0.16]))
 +        where <function isclose at 0x7fb1abe892b0> = np.isclose
FAILED tests/test_algos.py::test_bpz_wHDFN_prior[./tests/validation_10gal.pq-] - OSError: Unable to synchronously open file (file signature not found)
================== 2 failed, 4 passed, 129 warnings in 14.21s ==================

Before submitting
Please check the following:

  • I have described the situation in which the bug arose, including what code was executed, information about my environment, and any applicable data others will need to reproduce the problem.
  • I have included available evidence of the unexpected behavior (including error messages, screenshots, and/or plots) as well as a description of what I expected instead.
  • If I have a solution in mind, I have provided an explanation and/or pseudocode and/or task list.
@OliviaLynn OliviaLynn added the bug Something isn't working label Nov 30, 2023
@sschmidt23
Copy link
Collaborator

I took a look a this, the one test failing is due to small changes in the mode estimates for a few of the test galaxies, I'm not sure why that is happening, it could be some small update in numpy/scipy or something that slightly tweaks a probability or a random number. Nothing looks wrong, I think we can just update the test numbers (and maybe add an atol=2.e-02 or something so that we don't have to worry if a mode goes from .06 to 0.07).

The other error looks like it's coming from the attempt to read in the small parquetdata file in the tests directory, where tables_io is attempting to open ./tests/validation_10gal.pq as an hdf5 file rather than a parquet file. Did we make some change to tables_io that is just now hitting this? I thought that seeing the .pq file extension automatically triggered tables_io to read this in as a parquet file.

@sschmidt23
Copy link
Collaborator

As I just mentioned on slack, I see in the stack trace that this problem is cropping up in the rail/core/stage input_iterator, that was recently changed, and I'm guessing this is likely related to this issue that was recently created for rail on parquet files no longer working:
LSSTDESC/rail#116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants