Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDFs with all zeros in BPZ #28

Open
sschmidt23 opened this issue Jul 9, 2021 · 2 comments
Open

PDFs with all zeros in BPZ #28

sschmidt23 opened this issue Jul 9, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@sschmidt23
Copy link
Collaborator

I was playing around with the evaluation demo notebook and using BPZ in place of FlexZBoost, it threw an error because a handful of objects have weird colors and small errors, so the chi^2 fit is terrible, and the likelihood=e^-chi^2/2 ends up at 0.0 for all redshifts. This is obviously a problem when you try to normalize the PDF in qp, and the notebook threw an error. So, I should probably add a check to BPZ_lite to set these to a non-zero uniform value rather than 0.0.

@sschmidt23 sschmidt23 self-assigned this Jul 9, 2021
@sschmidt23 sschmidt23 added the bug Something isn't working label Jul 9, 2021
@eacharles
Copy link
Collaborator

This seems like it should be moved to an issue in qp for dealing with flags in general, which probably just means agreeing on a convention for how to use qp ancillary data to flag bad distributions.

@eacharles
Copy link
Collaborator

Second comment, this also related to the flag conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants