Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PureB #340

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

PureB #340

wants to merge 18 commits into from

Conversation

yomori
Copy link
Contributor

@yomori yomori commented Feb 17, 2024

Implementation of hybrideb and NaMaster in pureB to compute B-modes.

@damonge
Copy link
Contributor

damonge commented Jun 7, 2024

Has anyone tested the standard B-mode purification method for cosmic shear data?
My expectation was always that it would not work at all, since it requires a smooth differentiable mask, which is very difficult to achieve for cosmic shear without losing most of the area.

@yomori
Copy link
Contributor Author

yomori commented Jun 7, 2024

My gut feeling is the same as yours (I think the apodization scale has to be pretty wide too), which is why I didn't even bother. Might be able to do measure something if we apply constrained inpainting or something first (at which point the measurement isn't too meaningful).

@yomori yomori marked this pull request as ready for review June 21, 2024 14:28
@yomori yomori requested a review from joezuntz June 26, 2024 15:37
examples/desy1/pipeline_Bmodes.yml Show resolved Hide resolved
examples/desy3/config_Bmodes.yml Show resolved Hide resolved
txpipe/data_types/types.py Show resolved Hide resolved
txpipe/diagnostics.py Show resolved Hide resolved
txpipe/twopoint_null_tests.py Outdated Show resolved Hide resolved
txpipe/twopoint_null_tests.py Outdated Show resolved Hide resolved
txpipe/twopoint_null_tests.py Outdated Show resolved Hide resolved
txpipe/twopoint_null_tests.py Outdated Show resolved Hide resolved
txpipe/twopoint_null_tests.py Outdated Show resolved Hide resolved
txpipe/twopoint_null_tests.py Show resolved Hide resolved
@xuod
Copy link

xuod commented Jul 11, 2024

@damonge @yomori I did try pure B-mode on DES Y3, but because of all the tiny holes in the mask, the apodization drastically reduces the effective area (or equivalently reduces the weight of many areas in the footprint). So that makes the test lose statistical power.

@damonge
Copy link
Contributor

damonge commented Jul 11, 2024

Yep, indeed, this is the main problem with the standard purification approach. I could never convince myself that this would be useful for cosmic shear.

@yomori
Copy link
Contributor Author

yomori commented Jul 11, 2024

Yeah so thats why I have three modes of running this right now.
(a) Namaster with purify_b=False -- to replicate DES-Y3 what did.
(b) Namaster with purify_b=True -- if anyone wants to run it on idealized sim or something (just a flag change anyway).
(c) HybridEB -- the more robust way of computing BB.

If you are worried that someone will randomly run it with purify_b=True without knowing the caveats and use that in a paper, I can throw in a warning. If you really really want it to be taken out, I'm happy to do that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants