Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a __main__.py with the functionality of blinding a SACC file #21

Closed
arthurmloureiro opened this issue Feb 16, 2024 · 3 comments · Fixed by #40
Closed

Implement a __main__.py with the functionality of blinding a SACC file #21

arthurmloureiro opened this issue Feb 16, 2024 · 3 comments · Fixed by #40
Assignees
Labels
enhancement SACC SACC file format related issues

Comments

@arthurmloureiro
Copy link
Contributor

Implement a main function that can be called from the terminal and blinds a SACC file provided by the user.

@arthurmloureiro arthurmloureiro added enhancement SACC SACC file format related issues labels Feb 16, 2024
@arthurmloureiro arthurmloureiro self-assigned this Feb 16, 2024
@arthurmloureiro
Copy link
Contributor Author

This is going to be challenging because the build_likelihood() methods read automatically a sacc file.

The firecrown likelihood families demand that .read() method is called instantly and this method actually somehow filters the required data-points/binning/etc.. the likelihood "knows" how to get the theory-vector in the same shape of the (internally) selected data-vector. But there's no way of extracting that information from the likelihood so that it can be applied to an external data-vector, loaded outside the likelihood.

This really complicates things for blinding. The solution found so far would only work for a data-vector that is already being loaded into the firecrown likelihood.

@arthurmloureiro
Copy link
Contributor Author

This is somewhat related to LSSTDESC/firecrown#394 (comment)

@arthurmloureiro
Copy link
Contributor Author

@tilmantroester pointed out that jsonargparse module could be super useful for this!

https://jsonargparse.readthedocs.io/en/stable/#

@arthurmloureiro arthurmloureiro linked a pull request Jul 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement SACC SACC file format related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant