Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

just a few typos #6214

Merged
merged 1 commit into from
Oct 22, 2024
Merged

just a few typos #6214

merged 1 commit into from
Oct 22, 2024

Conversation

fchapoton
Copy link
Contributor

also fixing some rst code.

NOTE : There is invalid rst code in siegel_modular_forms/dimensions.py, which is just html inside rst blocks...

@roed314
Copy link
Contributor

roed314 commented Oct 22, 2024

Thanks!

@roed314 roed314 merged commit c20d637 into LMFDB:main Oct 22, 2024
13 checks passed
@roed314
Copy link
Contributor

roed314 commented Oct 22, 2024

Thanks for pointing out the problem with dimensions.py, We don't currently do any kind of documentation building, so docstrings are just read by developers editing the file. That being said, it would be better if these were changed to rst instead of html; feel free to make that change if you're interested and I'll review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fchapoton @roed314