Removing some math mode #5547
Merged
Removing some math mode #5547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwj61
force-pushed
the
special_sub_knowls
branch
from
dce4af2
to
ee08540
Compare
|
The actual changes are to say when things are not identified and adding statements explaining the font colors of subgroups |
|
When I look at the page above or another page like: 12856620672.u this PR seems to add "Group None" in a bunch of places in the profile. Is that intended? It looks strange to me. |
|
I didn't realize I did that ... looking into it. |
|
It actually might be something from earlier (maybe my earlier PR?) |
|
It looks like it is already in master. |
|
It looks like the issue is in web_groups.py line 99+. I'm going to merge this PR (as it didn't create this bug) and then try to fix that issue after this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the normal subgroup profile, this changes plain text from being text-inside-latex-math-mode to just text (for a quotient group).
http://127.0.0.1:37777/Groups/Abstract/400000000.bk
http://beta.lmfdb.org/Groups/Abstract/400000000.bk
Note, I am aware of another issue with this the display of quotients in the normal subgroup profile on this page, but am putting that off to another time.