Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suggested #49 #51

Closed
vrkansagara opened this issue Mar 11, 2024 · 1 comment · Fixed by #85
Closed

Fix suggested #49 #51

vrkansagara opened this issue Mar 11, 2024 · 1 comment · Fixed by #85
Labels
bug Something isn't working V3 To be fixed in version 3 V4 To be implemented in version 4

Comments

@vrkansagara
Copy link

      if (isset($data['user_id'])) {
        $data = $this->mapField('user_id', 'id', $data);
      }

$data = $this->mapField('user_id', 'id', $data);

#49

@visto9259
Copy link
Member

As a I mentioned in the code review, the change should be made in the mapField() function as this is where the warning is raised.
And making the change in the mapField() function will cover all cases where a fromKey is not found in the array.

@visto9259 visto9259 added the bug Something isn't working label Mar 12, 2024
@visto9259 visto9259 added V4 To be implemented in version 4 V3 To be fixed in version 3 labels Apr 17, 2024
visto9259 added a commit to visto9259/LmcUser that referenced this issue Jun 26, 2024
@visto9259 visto9259 mentioned this issue Jun 26, 2024
visto9259 added a commit that referenced this issue Jun 26, 2024
@vrkansagara vrkansagara removed their assignment Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working V3 To be fixed in version 3 V4 To be implemented in version 4
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants