Feautre/adapt opt #565
Draft
Feautre/adapt opt #565
+1,055
−458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drreynolds
reviewed
Sep 10, 2024
Co-authored-by: David Gardner <[email protected]>
Co-authored-by: David Gardner <[email protected]>
drreynolds
reviewed
Sep 17, 2024
Comment on lines
+47
to
+52
| Removed error floors from the SUNAdaptController implementations which could | ||
| unnecessarily limit the time size growth, particularly after the first step. | ||
|
|
||
| On the first two time steps, the Soderlind controller uses an I controller | ||
| instead of omitting unavailable terms. | ||
|
|
There was a problem hiding this comment.
I'm not sure that these are "bug fixes" per-se. Should these be moved to "enhancements" section above?
Comment on lines
+58
to
+64
| Removed error floors from the SUNAdaptController implementations which could | ||
| unnecessarily limit the time size growth, particularly after the first step. | ||
|
|
||
| On the first two time steps, the | ||
| :ref:`Soderlind controller <SUNAdaptController.Soderlind>` uses an I controller | ||
| instead of omitting unavailable terms. | ||
|
|
There was a problem hiding this comment.
I'm not sure that these are "bug fixes" per-se. Should these be moved to "enhancements" section above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft status while doing performance comparisons.
This branches of off
feature/rk_defaultswithfeature/min-errmerged in.Current adaptivity controller changes: