-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI (mingw): Install and build with SuiteSparse library #432
Conversation
@mmuetzel Can you sign your commit as mentioned in the contributing guide? |
Signed-off-by: Markus Mützel <[email protected]>
I rebased on a current head of the |
Yes, it looks good now. |
It looks like the CI failed because GCC 14 is stricter when it comes to automatically converting pointer types than previous versions. |
I opened #477 which hopefully addresses that issue. |
`long int` is 32 bits wide on systems that use an LLP64 data model (e.g., Windows). Use a type for which the C standard guarantees that it is 64-bit instead (i.e., `int64_t`). See the error in CI for PR #432. Signed-off-by: Markus Mützel <[email protected]> Co-authored-by: Cody Balos <[email protected]>
`long int` is 32 bits wide on systems that use an LLP64 data model (e.g., Windows). Use a type for which the C standard guarantees that it is 64-bit instead (i.e., `int64_t`). See the error in CI for PR #432. Signed-off-by: Markus Mützel <[email protected]> Co-authored-by: Cody Balos <[email protected]>
MSYS2 follows a rolling release model. I.e., most of its packages are quite new most of the time. Adding the SuiteSparse libraries in the CI tests for MSYS2 might help to detect potentially API changes early. Signed-off-by: Markus Mützel <[email protected]> Co-authored-by: Cody Balos <[email protected]> Co-authored-by: David Gardner <[email protected]>
MSYS2 follows a rolling release model. I.e., most of its packages are quite new most of the time.
Adding the SuiteSparse libraries in the CI tests for MSYS2 might help to detect potentially API changes early.