Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Release mode the default build type so users automatically get the fastest configuration #422

Merged
merged 24 commits into from
Feb 28, 2024

Conversation

balos1
Copy link
Member

@balos1 balos1 commented Feb 15, 2024

There have been many instances where users have compared performance of SUNDIALS with predecessor codes while using the default build settings, which did not include optimization flags. This PR makes Release mode the default, so optimization flags will be used by default.

drreynolds
drreynolds previously approved these changes Feb 15, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
doc/arkode/guide/source/Introduction.rst Outdated Show resolved Hide resolved
doc/cvode/guide/source/Introduction.rst Outdated Show resolved Hide resolved
doc/cvodes/guide/source/Introduction.rst Outdated Show resolved Hide resolved
doc/ida/guide/source/Introduction.rst Outdated Show resolved Hide resolved
doc/idas/guide/source/Introduction.rst Outdated Show resolved Hide resolved
doc/kinsol/guide/source/Introduction.rst Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
doc/arkode/guide/source/Introduction.rst Outdated Show resolved Hide resolved
doc/cvode/guide/source/Introduction.rst Outdated Show resolved Hide resolved
doc/cvodes/guide/source/Introduction.rst Outdated Show resolved Hide resolved
doc/ida/guide/source/Introduction.rst Outdated Show resolved Hide resolved
doc/idas/guide/source/Introduction.rst Outdated Show resolved Hide resolved
doc/kinsol/guide/source/Introduction.rst Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor update to make the lop level change log consistent with the others. Otherwise the changes look good.

Updating the default build type created some new warnings in the Jenkins CI that are causing it to fail and some tests are failing in the GitLab CI.

CHANGELOG.md Outdated Show resolved Hide resolved
@gardner48 gardner48 merged commit 0f2d49d into develop Feb 28, 2024
20 of 24 checks passed
@gardner48 gardner48 deleted the feature/default-to-release-build branch February 28, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants