-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make Release mode the default build type so users automatically get the fastest configuration #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he fastest configuration
balos1
requested review from
gardner48,
cswoodward and
drreynolds
as code owners
February 15, 2024 18:59
drreynolds
previously approved these changes
Feb 15, 2024
gardner48
requested changes
Feb 15, 2024
balos1
commented
Feb 15, 2024
balos1
commented
Feb 15, 2024
Co-authored-by: David Gardner <[email protected]>
gardner48
requested changes
Feb 15, 2024
gardner48
requested changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor update to make the lop level change log consistent with the others. Otherwise the changes look good.
Updating the default build type created some new warnings in the Jenkins CI that are causing it to fail and some tests are failing in the GitLab CI.
Co-authored-by: David Gardner <[email protected]>
…' into feature/default-to-release-build
…ros' into feature/default-to-release-build
…ected side effects
gardner48
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been many instances where users have compared performance of SUNDIALS with predecessor codes while using the default build settings, which did not include optimization flags. This PR makes Release mode the default, so optimization flags will be used by default.