Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling in ida #385

Merged
merged 27 commits into from
Dec 13, 2023

Conversation

balos1
Copy link
Member

@balos1 balos1 commented Dec 6, 2023

No description provided.

src/ida/ida.c Outdated Show resolved Hide resolved
src/ida/ida.c Outdated Show resolved Hide resolved
src/ida/ida.c Outdated Show resolved Hide resolved
src/ida/ida.c Outdated Show resolved Hide resolved
src/ida/ida.c Outdated Show resolved Hide resolved
src/ida/ida.c Outdated Show resolved Hide resolved
src/ida/ida.c Outdated Show resolved Hide resolved
src/ida/ida.c Outdated Show resolved Hide resolved
src/ida/ida.c Outdated Show resolved Hide resolved
src/ida/ida_io.c Outdated Show resolved Hide resolved
Copy link
Collaborator

@drreynolds drreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor commenting error, otherwise this looks good.

src/ida/ida.c Outdated Show resolved Hide resolved
Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also noticed IDA does not have an error handler unit test like CVODE and ARKODE

doc/ida/guide/source/Introduction.rst Outdated Show resolved Hide resolved
doc/ida/guide/source/Usage/index.rst Show resolved Hide resolved
include/ida/ida.h Show resolved Hide resolved
src/ida/ida.c Show resolved Hide resolved
src/ida/ida_ls.c Show resolved Hide resolved
src/ida/ida.c Outdated Show resolved Hide resolved
Co-authored-by: David Gardner <[email protected]>
@balos1 balos1 merged commit a01253c into feature/error-handling-staging Dec 13, 2023
9 of 14 checks passed
@balos1 balos1 deleted the feature/error-handling-ida branch December 13, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants