Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix::orthogonalize() works only for distributed case. #232

Open
dreamer2368 opened this issue Jul 29, 2023 · 1 comment
Open

Matrix::orthogonalize() works only for distributed case. #232

dreamer2368 opened this issue Jul 29, 2023 · 1 comment
Labels

Comments

@dreamer2368
Copy link
Collaborator

Based on the definition in lib/linalg/Matrix.cpp, void Matrix::orthogonalize() works only when the matrix is distributed (in parallel case). It should have a line:

CAROM_VERIFY(distributed());
@cval26
Copy link
Collaborator

cval26 commented Sep 28, 2023

@dreamer2368 Can you elaborate on this?

I'm working on PR #239 which solves a bug in the orthogonalize() method and adds an incremental method orthogonalize_last(). The PR also includes unit tests for those methods which run successfully for non-distributed matrices.

Do those changes solve the issue you're referring to here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants