Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve scale gateway listeners test #567

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Improve scale gateway listeners test #567

merged 1 commit into from
Nov 8, 2024

Conversation

averevki
Copy link
Contributor

  • Make scale gateway listeners test more stable and comprehensive
  • Add "affected by policy" condition to use with .wait_until()

@averevki averevki added the enhancement Improvement to existing test label Oct 25, 2024
@averevki averevki requested a review from jsmolar October 25, 2024 14:21
@averevki averevki self-assigned this Oct 25, 2024
trepel
trepel approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test passes for me. I like this, much nicer.

@jsmolar jsmolar merged commit e93b295 into Kuadrant:main Nov 8, 2024
3 checks passed
@averevki averevki deleted the improve-scale-listeners branch November 11, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmolar jsmolar jsmolar approved these changes

@trepel trepel trepel approved these changes

Assignees

@averevki averevki

Labels
enhancement Improvement to existing test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@averevki @trepel @jsmolar