Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip geo test if dns not configured #537

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Skip geo test if dns not configured #537

merged 1 commit into from
Sep 17, 2024
+7 −3

Conversation

averevki
Copy link
Contributor

No description provided.

@averevki averevki added the enhancement Improvement to existing test label Sep 16, 2024
@averevki averevki self-assigned this Sep 16, 2024
azgabur
azgabur approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@azgabur azgabur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to make multicluster target having flag --enforce the skip will be treated as error.

@azgabur azgabur mentioned this pull request Sep 17, 2024
Merged
trepel
trepel approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@trepel trepel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azgabur approved this one (he's apparently fine with this) so I am approving as well.

@averevki averevki merged commit 652abec into Kuadrant:main Sep 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trepel trepel trepel approved these changes

@azgabur azgabur azgabur approved these changes

@jsmolar jsmolar Awaiting requested review from jsmolar

Assignees

@averevki averevki

Labels
enhancement Improvement to existing test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@averevki @trepel @azgabur