Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for html generation #536

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

azgabur
Copy link
Contributor

@azgabur azgabur commented Sep 12, 2024

Inpiration from sister testsuite https://github.com/3scale-qe/3scale-tests/blob/376263a7b94faced2698b920f9599c39e1d38b44/Makefile#L33

Makes the html report include CSS instead of creating extra directory to keep the css file.

Signed-off-by: Alex Zgabur <[email protected]>
@azgabur azgabur added good first issue Good for newcomers refactor Refactor with same functionality enhancement Improvement to existing test and removed refactor Refactor with same functionality labels Sep 12, 2024
Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Validated using:
html=1 make ./testsuite/tests/singlecluster/gateway/test_basic.py

With this PR the assets directory with CSS was not created and the CSS code was included in head HTML tag of HTML report as expected.

@averevki averevki merged commit 30e3677 into Kuadrant:main Sep 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing test good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants