-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat AuthConfig responses section #220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azgabur
reviewed
Jul 21, 2023
testsuite/tests/kuadrant/authorino/conditions/section_conditions/test_response_condition.py
Outdated
Show resolved
Hide resolved
averevki
force-pushed
the
response-section
branch
from
July 25, 2023 08:41
8484a65
to
cb3d31e
Compare
averevki
force-pushed
the
response-section
branch
2 times, most recently
from
August 2, 2023 11:34
1329198
to
2d32434
Compare
rebase^ |
averevki
force-pushed
the
response-section
branch
from
August 2, 2023 14:50
2d32434
to
32486ee
Compare
rebase^ |
pehala
reviewed
Aug 3, 2023
mganisin
reviewed
Aug 3, 2023
averevki
force-pushed
the
response-section
branch
from
August 4, 2023 13:13
32486ee
to
29fd00f
Compare
pehala
approved these changes
Aug 4, 2023
jsmolar
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reformat AuthConfig responses section so that response can be added same as the elements of other sections.
New dataclass
Property
was introduced. Property is aValue
with name.Example of adding different types of reponses: