Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat AuthConfig responses section #220

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

averevki
Copy link
Contributor

@averevki averevki commented Jul 12, 2023

Reformat AuthConfig responses section so that response can be added same as the elements of other sections.
New dataclass Property was introduced. Property is a Value with name.

Example of adding different types of reponses:

authorization.responses.json("header", [Property("anything", Value("one"))])
authorization.responses.plain("header", ValueFrom("context.request.http.method"))
authorization.responses.wristband("wristband", wristband_endpoint, wristband_secret, wrapper="envoyDynamicMetadata")

@averevki averevki force-pushed the response-section branch 2 times, most recently from 1329198 to 2d32434 Compare August 2, 2023 11:34
@averevki
Copy link
Contributor Author

averevki commented Aug 2, 2023

rebase^

@averevki
Copy link
Contributor Author

averevki commented Aug 2, 2023

rebase^

@averevki averevki requested a review from azgabur August 4, 2023 14:19
@pehala pehala requested a review from mganisin August 7, 2023 15:07
@pehala pehala merged commit 5bce78a into Kuadrant:main Aug 8, 2023
1 check passed
@averevki averevki deleted the response-section branch November 11, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants