Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new ReconcileResource based on the topology #916

Open
eguzki opened this issue Oct 8, 2024 · 1 comment
Open

new ReconcileResource based on the topology #916

eguzki opened this issue Oct 8, 2024 · 1 comment

Comments

@eguzki
Copy link
Contributor

eguzki commented Oct 8, 2024

Base reconciler's ReconcileResource has been very helpful.

With the new approach based on a pre-computed topology, we should re-consider using it. That ReconcileResource performs a Get from the api server. The new agreed convention is to get this resource from the topology.

Today, it is being used at least in the consoleplugin reconciler

@eguzki
Copy link
Contributor Author

eguzki commented Oct 8, 2024

My vote: we keep using ReconcileResource. That brings update mutators. IMO, update mutators is a perfect match for operator reconciliation pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant