Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent labeling for Operator metric Services #846

Open
jsmolar opened this issue Sep 2, 2024 · 1 comment
Open

Consistent labeling for Operator metric Services #846

jsmolar opened this issue Sep 2, 2024 · 1 comment

Comments

@jsmolar
Copy link
Contributor

jsmolar commented Sep 2, 2024

Current labeling for Operator Metric Services

  • kuadrant-operator-metrics - control-plane=controller-manager
  • authorino-operator-metrics - control-plane=authorino-operator
  • limitador-operator-metrics - control-plane=controller-manager
  • dns-operator-controller-manager-metrics-service - control-plane=dns-operator-controller-manager

Proposed Change

To achieve consistency in the labeling of Operator metric services, I propose aligning the labels according to the pattern implemented by the authorino-operator, or by a new common pattern.

Two potential approaches:

  1. Change label value to reflect correct service
    kuadrant-operator-metrics - control-plane=kuadrant-operator
    authorino-operator-metrics - control-plane=authorino-operator
    limitador-operator-metrics - control-plane=limitador-operator
    dns-operator-metrics - control-plane=dns-operator

  2. Change both key and value
    kuadrant-operator-metrics - component=kuadrant-operator
    authorino-operator-metrics - component=authorino-operator
    limitador-operator-metrics - component=limitador-operator
    dns-operator-metrics - component=dns-operator

@david-martin
Copy link
Contributor

When labels are changed, please also update the ServiceMonitors as needed to ensure they target the correct Services.
See #953 (comment) for related discussion on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants