New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: dnsrecord never stops trying to update on conflict #210

Open

mikenairn opened this issue Aug 11, 2024 · 0 comments

Labels

bug

Member

mikenairn commented Aug 11, 2024

What

The dnsrecord controller no longer stops trying to update the record in the provider zone when it is trying to update the same generation too often. Look like a regression introduced by #100, at least i can't find the equivalent of this anywhere now https://github.com/Kuadrant/dns-operator/pull/100/files#diff-adacb6a4589c65c2d853c0f59ca02d6b8fb50bb388b41de1d13e99b0d128cfe1L405

if dnsRecord.Status.WriteCounter < WriteCounterLimit {
   dnsRecord.Status.WriteCounter++
   wrtiteCounter.WithLabelValues(dnsRecord.Name, dnsRecord.Namespace).Inc()
   logger.V(1).Info("Changes needed on the same generation of record")
} else {

mikenairn added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment