Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DNSRecord deletion to better ensure changes are persisted #181

Open
mikenairn opened this issue Jul 4, 2024 · 1 comment
Open

Comments

@mikenairn
Copy link
Member

mikenairn commented Jul 4, 2024

What

Update the dnsrecord deletion logic to better cover the situation where multiple writes could be happening to the same records.
We currently do a single validation loop after a delete that ensures that the expected result of a delete request is persisted, but this happens very quickly and it is possible, at scale, for other controllers to add back values after this validation attempt.

The logic needs to be changed here to allow longer and more validation attempts after a delete, especially when multiple owners are in play.

Note: This is only really observable when using AWS and with multiple DNSRecords, all contributing to a shared record set, are deleting at the same time.

Can be re-created by running the test-e2e-multi test suite on AWS:

make local-setup DEPLOY=true DEPLOYMENT_SCOPE=namespace DEPLOYMENT_COUNT=20
make test-e2e-multi TEST_DNS_MANAGED_ZONE_NAME=dev-mz-aws TEST_DNS_NAMESPACES=dns-operator DEPLOYMENT_COUNT=20
@mikenairn mikenairn added this to the Kuadrant v1 milestone Jul 4, 2024
@mikenairn mikenairn self-assigned this Sep 4, 2024
@mikenairn mikenairn removed their assignment Sep 11, 2024
@mikenairn
Copy link
Member Author

While testing this a few test related issues came up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants