Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Preserve Error Messages During Stub Generation #11374

Merged

Conversation

matekelemen
Copy link
Contributor

The stub generating script swallowed everything from stdout and stderr and displayed only a very limited error message if something failed. This PR lets stderr past, to get tracebacks in their full glory (the junk generated by Kratos apps while importing is still blocked) if an exception occurs.

@matekelemen matekelemen added Compilation FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Jul 10, 2023
@matekelemen matekelemen requested a review from a team as a code owner July 10, 2023 12:16
sunethwarna
sunethwarna previously approved these changes Jul 10, 2023
Copy link
Member

@sunethwarna sunethwarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @matekelemen.

@matekelemen matekelemen merged commit db8d23f into KratosMultiphysics:master Jul 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compilation FastPR This Pr is simple and / or has been already tested and the revision should be fast
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants