From 359f87e7737a161cf9c5962cb47313b71d0a22d3 Mon Sep 17 00:00:00 2001 From: sunethwarna Date: Wed, 5 Jun 2024 13:22:18 +0200 Subject: [PATCH] revert --- kratos/containers/pointer_vector_set.h | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/kratos/containers/pointer_vector_set.h b/kratos/containers/pointer_vector_set.h index 194a1fc6991a..f64b7068c538 100644 --- a/kratos/containers/pointer_vector_set.h +++ b/kratos/containers/pointer_vector_set.h @@ -574,8 +574,13 @@ class PointerVectorSet final mData.push_back(value); mSortedPartSize = mData.size(); return iterator(mData.end() - 1); + } else if (EqualKeyTo(KeyOf(*value))(*itr_pos)) { + // already found existing element with the same key, hence returning the existing element. + return iterator(itr_pos); } else { - return UniqueInsert(value); + // insert the new value before the itr_pos. + mSortedPartSize = mData.size() + 1; + return mData.insert(itr_pos, value); } } @@ -606,7 +611,7 @@ class PointerVectorSet final return iterator(mData.end() - 1); } else { // given position is invalid. Hence, discarding the hint. - return UniqueInsert(value); + return insert(value); } } else if (position_hint == cbegin()) { // trying to insert at the front. @@ -617,7 +622,7 @@ class PointerVectorSet final return mData.insert(mData.begin(), value); } else { // given position is invalid. Hence, discarding the hint. - return UniqueInsert(value); + return insert(value); } } else { // trying to insert at an arbitrary position. @@ -626,7 +631,7 @@ class PointerVectorSet final return mData.insert(mData.begin() + (position_hint - cbegin()), value); } else { // given position is invalid. Hence, discarding the hint. - return UniqueInsert(value); + return insert(value); } } } @@ -1178,19 +1183,6 @@ class PointerVectorSet final } } - iterator UniqueInsert(const TPointerType& value) - { - auto itr_pos = std::lower_bound(mData.begin(), mData.end(), KeyOf(*value), CompareKey()); - if (EqualKeyTo(KeyOf(*value))(*itr_pos)) { - // already found existing element with the same key, hence returning the existing element. - return iterator(itr_pos); - } else { - // insert the new value before the itr_pos. - mSortedPartSize = mData.size() + 1; - return mData.insert(itr_pos, value); - } - } - ///@} ///@name Serialization ///@{