Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparseCtrl-RGB, flashing in generated frames #476

Open
aihopper opened this issue Sep 17, 2024 · 2 comments
Open

SparseCtrl-RGB, flashing in generated frames #476

aihopper opened this issue Sep 17, 2024 · 2 comments

Comments

@aihopper
Copy link

aihopper commented Sep 17, 2024

Here is a minimal repro case.

We'll start with something that works so we can keep it as a reference. This basic workflow below generates a video of a running person (SparseCtrl-RGB module is bypassed so all works as expected):

ComfyUI Workflow Result
readme_00001 video

Now I enable the SparseCtrl-RGB module and ask it to interpolate every other frame, notice the flashing:

ComfyUI Workflow Result
readme_00002 video

notes:

  • the sampling method when generating the reference animation and when interpolating is the same
  • the only difference is adding SparseCtrl-RGB
  • The flashing happens because the frames generated by AnimateDiff are lighter and have a higher contrast.
  • In other repro cases colors shift to orange tones and overall the images degrade.
  • A similar thing happens with video prediction.
  • Note that the reference sequence was generated by AniumateDiff, this means it should be represented optimally in the latent space.

Any help is ideas on how to debug this are very welcome.
Cheers

@aihopper
Copy link
Author

Please note this issue also happens in the developers repo: guoyww/AnimateDiff#387

Hopefully this helps others set expectations and saves them some time.

@aihopper aihopper changed the title Using SparseCtrl-RGB causes flashing in generated frames SparseCtrl-RGB, flashing in generated frames Sep 17, 2024
@rocky533
Copy link

RGB controls are limited, with that flashing appearing anytime you use it for the full duration. Setting end at time to .4-.6 can stop this, as well as setting soft scaled weights on the controls at .825 - .9. Both these minimize the flashing, but don't completely resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants