Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct RestSharp snippets (return type and Method enum) #366

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

michaelgwelch
Copy link
Contributor

@michaelgwelch michaelgwelch commented Sep 15, 2024

Ensure that code snippets use enum members that are pascal cased and not upper cased. For example use Method.Get instead of Method.GET to ensure the snippets can compile.

Also removes usage of unknown type IRestResponse

fixes #365 #367 #312

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2024

CLA assistant check
All committers have signed the CLA.

@michaelgwelch michaelgwelch changed the title correct the casing of Method enums in RestSharp snippets correct RestSharp snippets (return type and Method enum) Sep 15, 2024
Ensure that code snippets use enum members that are pascal cased and
not upper cased. For example use `Method.Get` instead of `Method.GET` to
ensure the snippets can compile.

fixes Kong#365

use `var` for return "type" of RestSharp request response

The type `IRestResponse` doesn't exist in latest client (version 112)

fixes Kong#367
@filfreire filfreire merged commit d107479 into Kong:master Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSharp RestSharp snippets don't generate valid members of RestSharp.Method enum
3 participants