Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore entities attached to another entity with no Konnect control plane reference #629

Open
1 task
randmonkey opened this issue Sep 23, 2024 · 0 comments
Open
1 task

Comments

@randmonkey
Copy link
Contributor

randmonkey commented Sep 23, 2024

Problem Statement

In the current reconcilers, if an entity (like KongRoute and KongTarget) is attached to another entity (KongService or KongUpstream) that has Programmed condition set but the entity being attached to (KongService or KongTarget) does not have a ControlPlaneRef, the reconciler will return an error in the Reconcile method. This would cause endless reconciliation backoff for the entities attached to another entity that does not have a Konnect control plane reference (for example, some other controllers create them in on-prem Kong gateways.).
...

Proposed Solution

Ignore the entity in Konnect entity reconciler if it is attached to another entity that does not have a Konnect control plane ref. Because the situation means that the entity (and the entity it attached to) are not controlled by Konnect.
...

Additional Information

...

Acceptance Criteria

  • The entities attached to another entity with no Konnect control plane reference does not fall into endless reconciliation backoff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant