Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default konnect url with konnect addr flag not accounted for. #1398

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

Prashansa-K
Copy link
Contributor

Previously, if a deck command was issued with --konnect-addr flag but with the default konnectUrl https://us.api.konghq.com, the flag value was getting ignored as deck could not figure out if it was passed by flag or not. This change ensures that if the flag is set, deck commands are issued against Konnect.

Fixes: #1385

Previously, if a deck command was issued with --konnect-addr flag
but with the default konnectUrl https://us.api.konghq.com, the
flag value was getting ignored as deck could not figure out
if it was passed by flag or not. This change ensures that if the
flag is set, deck commands are issued against Konnect.

Fixes: #1385
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.08%. Comparing base (a50b695) to head (4cacba6).

Files with missing lines Patch % Lines
cmd/common.go 0.00% 2 Missing ⚠️
cmd/root.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
- Coverage   29.16%   29.08%   -0.08%     
==========================================
  Files          59       59              
  Lines        5211     5215       +4     
==========================================
- Hits         1520     1517       -3     
- Misses       3583     3589       +6     
- Partials      108      109       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd add a test to for that if possible but I'm not sure how realistic it is given that we rely on package level variables and adding tests (in this PR) could require a fair amount of refactoring.

Please add a changelog entry for this.

@Prashansa-K Prashansa-K merged commit fd1fec7 into main Sep 25, 2024
19 checks passed
@Prashansa-K Prashansa-K deleted the fix/konnect-addr-flag-issue branch September 25, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if --konnect-addr is set
3 participants