Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(tests): test against go stable & oldstable #1245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gszr
Copy link
Member

@gszr gszr commented Mar 13, 2024

  • Change the tests and codeql-analysis workflows to run against both Go stable and oldstable. (If we do not want to test against both, please let me know.)
  • Change remaining workflows to run against stable - rather than hardcoding

@gszr gszr requested a review from a team March 13, 2024 19:27
@gszr gszr marked this pull request as draft March 13, 2024 19:29
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.69%. Comparing base (2af58c0) to head (8c67fa1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1245   +/-   ##
=======================================
  Coverage   21.69%   21.69%           
=======================================
  Files          53       53           
  Lines        5453     5453           
=======================================
  Hits         1183     1183           
  Misses       4177     4177           
  Partials       93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gszr gszr marked this pull request as ready for review March 13, 2024 19:34
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Prashansa-K
Copy link
Contributor

@gszr Could you please resolve the conflicts that are being shown here?

I had added some changes here: #1336 to address this issue. So, in some places we may have to keep the version same as go.mod so that the released version and project version golang match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants