Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty smart collections cause exception when evaluating delete if less condition #2274

Open
chazlarson opened this issue Oct 16, 2024 · 0 comments · Fixed by #2275
Open

empty smart collections cause exception when evaluating delete if less condition #2274

chazlarson opened this issue Oct 16, 2024 · 0 comments · Fixed by #2275
Assignees
Labels
enhancement New feature or request priority:medium Medium priority bug or feature status:working Working on this bug or feature

Comments

@chazlarson
Copy link
Contributor

Version Number

2.1.0

What branch are you on?

master

Describe the Bug

Here, in operations.py:

            less_check = True
            if less_in is not None:
                less_check = col_in.childCount < less_in

We're assuming childCount won't be None. If it is, like an empty smart collection, Kometa throws:

| TypeError: '<' not supported between instances of 'NoneType' and 'int'                             |

No need for this. There should be guardrails.

Relevant Collection/Overlay/Playlist Definition

No response

Logs

No response

@chazlarson chazlarson added bug Bug is with Plex Meta Manager status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Oct 16, 2024
@chazlarson chazlarson added enhancement New feature or request priority:medium Medium priority bug or feature status:working Working on this bug or feature and removed bug Bug is with Plex Meta Manager status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Oct 16, 2024
@chazlarson chazlarson linked a pull request Oct 16, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium Medium priority bug or feature status:working Working on this bug or feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants