[Defaults]: People Defaults Poster and Contents Mis-Match

[McBrideMusings]

Link to File

https://gist.github.com/McBrideMusings/248605c83bbb72fb73d7c483da91e140

Version Number

2.0.1

What branch are you on?

master

Describe the Bug

When using the People/Director Default collection the director John Waters TMDB correctly references the director's work but uses the actor John Waters TMDB portrait for the poster.

[bullmoose20]

Link to File

https://gist.github.com/McBrideMusings/248605c83bbb72fb73d7c483da91e140

Version Number

2.0.1

What branch are you on?

master

Describe the Bug

When using the People/Director Default collection the director John Waters TMDB correctly references the director's work but uses the actor John Waters TMDB portrait for the poster.

Can you share the proper link on tmdb for this person so we can adjust please?

[McBrideMusings]

Sure, see below

John Waters the director
https://www.themoviedb.org/person/10367-john-waters?language=en-US

John Waters the actor
https://www.themoviedb.org/person/1068123-john-waters?language=en-US

[YozoraXCII]

@bullmoose20 has anything been done for this? Can this be closed?

[bullmoose20]

So the issue is that there are two legitimate people with the same name... John Waters.
Our repo is based on names.... so Kometa looks for "John Waters"" and finds the only John Waters in our repo... which is the Actor: https://github.com/Kometa-Team/People-Images-rainier/tree/master/J

So when the Director is called, Kometa looks for John Waters and finds the John Waters in the repo which is the Actor and then applies it as the Director.

We could create the Director as "John Waters" and call the file John Waters2

This has been a long standing issue for years in terms of duplicate names.

The team had implemented an "offset" flag to try and address this however the issue is that tmdb will change the search order of the names returned so that sometimes the John Waters you want is not the second one.

[McBrideMusings]

That problem makes sense, but based on the config you know that I'm (or any other user looking for a name) is looking for the Director not the Actor. At least SAG requires Actors to have unique names, not sure if the DGA has the same by-law but when I search for this director's name at least I don't see any overlap

https://www.dga.org/The-Guild/Members

I'm not sure how the search is implemented, but could you search both by name and title? At least with Actors that should always work by their own by-laws, and that would likely resolve most of conflicts of the same nature.

Looking at the TMBD API Response, there's a
"known_for_department": "Acting",

field, that returns Directing for directors, seems like that string could be used to properly map the right person based on whether they're in the actor or director default.

also, I don't know if TMBD Ids are supported but if one could plug in the ID directly instead of a name that seems like it would create a workaround for even the most narrow of edge cases

[bullmoose20]

https://raw.githubusercontent.com/Kometa-Team/People-Images-rainier/master/J/Images/John%20Waters2.jpg

https://raw.githubusercontent.com/Kometa-Team/People-Images-rainier/master/J/Images/John%20Waters.jpg

Both are now there... the Actor is John Waters.jpg and the Director is John Waters2.jpg

[bullmoose20]

That problem makes sense, but based on the config you know that I'm (or any other user looking for a name) is looking for the Director not the Actor. At least SAG requires Actors to have unique names, not sure if the DGA has the same by-law but when I search for this director's name at least I don't see any overlap

https://www.dga.org/The-Guild/Members

I'm not sure how the search is implemented, but could you search both by name and title? At least with Actors that should always work by their own by-laws, and that would likely resolve most of conflicts of the same nature.

Looking at the TMBD API Response, there's a "known_for_department": "Acting",

field, that returns Directing for directors, seems like that string could be used to properly map the right person based on whether they're in the actor or director default.

also, I don't know if TMBD Ids are supported but if one could plug in the ID directly instead of a name that seems like it would create a workaround for even the most narrow of edge cases

Well... I wish it was as simple as "Hey I'm asking for the director when I am using the Directors default from Kometa". Why? because use the Tom Holland example pasted above... 3 actors and 1 director. How would we know which Tom Holland Actor is needed by Kometa to create the proper Tom Holland Actor collection?

The fundamental fix would be to leverage some kind of tmdbID which is unique per person. This would require a rewrite of all that logic within Kometa. And even then, from what I understood, Kometa asks Plex for the cast of people in a movie to come up with the collections and Plex returns NAMES and not IDs (I'd like either @chazlarson or @meisnate12 to confirm this logic). As such, we can only work with names when querying tmdb or our repo for the poster image.

https://kometa.wiki/en/nightly/files/updates/?h=offset
tmdb_person_offset is what we implemented to try and address this and like I mentioned above, tmdb will sometimes return a different order so the tmdb_person_offset is not perfect.